-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[STATS] Marking approximate points + general improvements #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bragov4ik
force-pushed
the
kirillivanov/stats-approx-points
branch
from
April 17, 2024 14:58
52a0760
to
290811c
Compare
bragov4ik
commented
Apr 17, 2024
bragov4ik
requested review from
sevenzing and
rimrakhimov
and removed request for
rimrakhimov
April 18, 2024 10:40
sevenzing
reviewed
Apr 18, 2024
sevenzing
reviewed
Apr 18, 2024
sevenzing
reviewed
Apr 18, 2024
sevenzing
reviewed
Apr 18, 2024
…tion changing user) This reverts commit 38d23a8.
bragov4ik
force-pushed
the
kirillivanov/stats-approx-points
branch
from
April 18, 2024 12:53
22ddaeb
to
1d93f08
Compare
sevenzing
reviewed
Apr 23, 2024
sevenzing
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Approximate points marking:
Point
in proto) indicating whether the data is approximate (whether it should be drawn as such). Currently all those marks are placed on trailing subsequent points.false
values in json serialization for efficiency. Absence of the field should be treated asfalse
(meaning the data is not approximate == exact)Noticeable changes in stats service:
Other:
..::now()
during update (for better testability)